On Thu, Apr 25, 2024 at 12:17 PM John Naylor <johncnaylo...@gmail.com> wrote: > > On Thu, Apr 25, 2024 at 9:50 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > > > > I saw a SIGSEGV there when using tidstore to write a fix for something > > > else. > > > Patch attached. > > > > Great find, thank you for the patch! > > +1 > > (This occurred to me a few days ago, but I was far from my computer.) > > With the purge function that Noah proposed, I believe we can also get > rid of the comment at the top of the .sql test file warning of a > maintenance hazard: > ..."To avoid adding duplicates, > -- each call to do_set_block_offsets() should use different block > -- numbers."
Good point. Removed. > > > of do_gset_block_offset() and check_set_block_offsets(). If these are > > annoying, we can remove the cases of array[1] and array[1,2]. > > Let's keep those -- 32-bit platforms should also exercise this path. Agreed. I've attached a new patch. I'll push it tonight, if there is no further comment. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
v2-0001-radixtree-Fix-SIGSEGV-at-update-of-embeddable-val.patch
Description: Binary data
