2018-06-29 15:55 GMT-03:00 Dave Cramer <davecra...@gmail.com>: > While trying to figure out this code I found > > https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/replication/logical/logical.c;h=61588d626f608006196c769ad9807f1d3ac592e9;hb=HEAD#l913 > > What function should it be referring to ? > LogicalIncreaseXminForSlot (it is a few lines above). It has been like that since logical decoding was introduced. The trivial patch fixes it.
-- Euler Taveira Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
diff --git a/src/backend/replication/logical/logical.c b/src/backend/replication/logical/logical.c index 61588d6..c2d0e0c 100644 --- a/src/backend/replication/logical/logical.c +++ b/src/backend/replication/logical/logical.c @@ -910,7 +910,7 @@ LogicalIncreaseXminForSlot(XLogRecPtr current_lsn, TransactionId xmin) * Mark the minimal LSN (restart_lsn) we need to read to replay all * transactions that have not yet committed at current_lsn. * - * Just like IncreaseRestartDecodingForSlot this only takes effect when the + * Just like LogicalIncreaseXminForSlot this only takes effect when the * client has confirmed to have received current_lsn. */ void
