On Fri, Jun 29, 2018 at 06:02:07PM -0400, Bruce Momjian wrote: > On Thu, Jun 28, 2018 at 09:46:17AM -0700, Peter Geoghegan wrote: >> * Don't assume that you haven't broken the doc build if you make even >> a trivial doc change. Removing a GUC can break instances in the >> release notes where they're referenced. Even grep can miss this, since >> references to the GUC will have dashes rather than underscores, plus >> possibly other variations. > > Yes, I even check the docs after whitespace changes.
Could it be possible to mention as well to run pgindent before a commit? After the indent run done for 11 beta 1, and it was just a matter of days before some garbage diffs have accumulated in the C code, which makes local runs more annoying when the same files are touched. -- Michael
signature.asc
Description: PGP signature
