Daniel Gustafsson <dan...@yesql.se> writes: >> On 5 Jul 2022, at 18:59, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Given the lack of field complaints, it's probably not worth trying >> to do anything to restore that capability. But we really ought to >> update pg_upgrade's code and docs in pre-v15 branches to say that >> the minimum supported source version is 9.0.
> (reviving an old thread from the TODO) > Since we never got around to doing this we still refer to 8.4 as a possible > upgrade path in v14 and older. Oh, yeah, that seems to have fallen through a crack. > The attached takes the conservative approach of raising the minimum supported > version to 9.0 while leaving the code to handle 8.4 in place. While it can be > removed, the risk/reward tradeoff of gutting code in backbranches doesn't seem > appealing since the code will be unreachable with this check anyways. Yeah, it's not worth working harder than this. I do see one typo in your comment: s/supported then/supported when/. LGTM otherwise. regards, tom lane