On Wed, 22 May 2024 at 00:35, Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > > On 2024-May-21, David Rowley wrote: > > > I've attached 2 patches. > > > > 0001 is a simple revert of Tom's revert (7204f3591). > > 0002 fixes the issue reported by Hubert. > > I would like to request that you don't keep 0001's message as you have > it here. It'd be more readable to take 66c0185a3d14's whole commit > message with a small suffix like "try 2" in the commit title, and add an > additional second paragraph stating it was transiently reverted by > 7204f35919b7. Otherwise it's harder to make sense of the commit on its > own later.
Thanks for having a look. I was planning to have the commit message as per attached. I'd only split the patch for ease of review per request of Tom. I should have mentioned that here. I would adjust the exact wording in the final paragraph as required depending on what plan materialises. This also fixes up the comment stuff that Heikki mentioned. David
v2-0001-Allow-planner-to-use-Merge-Append-to-efficiently-.patch
Description: Binary data
