On 2018/07/03 11:49, Robert Haas wrote: > On Mon, Jul 2, 2018 at 1:46 AM, Ashutosh Bapat > <ashutosh.ba...@enterprisedb.com> wrote: >> This constraint was added to the partitioned table and inherited from >> there. If user wants to drop that constraint for some reason, this >> error message doesn't help. The error message tells why he can't drop >> it, but doesn't tell, directly or indirectly, the user what he should >> do in order to drop it. > > That doesn't really sound like an actual problem to me. If the error > is that the constraint is inherited, that suggests that the solution > is to find the place from which it got inherited and drop it there. > And that's in fact what you have to do. What's the problem? I mean, > we could add a hint, but it's possible to make yourself sound dumb by > giving hints that are basically obvious implications from the error > message. Nobody wants this sort of thing: > > rhaas=# drop table foo; > ERROR: table "foo" does not exist > HINT: Try dropping a table with a different name that does exist, or > first create this table before trying to drop it. > > A hint here wouldn't be as silly as that, but I think it is > unnecessary. I doubt there's likely to be much confusion here.
I have to agree with that. "cannot drop inherited ..." conveys enough for a user to find out more. Thanks, Amit
