On Fri, 24 May 2024 at 00:09, Kyotaro Horiguchi <horikyota....@gmail.com> wrote: > Along with rebasing, I changed the interface of XLogFsyncFile() to > return a boolean instead of an error message.
Two notes after looking at this quickly during the advanced patch feedback session: 1. I would maybe split 0003 into two separate patches. One to make SET UNLOGGED fast, which seems quite easy to do because no WAL is needed. And then a follow up to make SET LOGGED fast, which does all the XLOG_FPI stuff. 2. When wal_level = minital, still some WAL logging is needed. The pages that were changed since the last still need to be made available for crash recovery.
