Hi.
I think we may have simply forgotten to do $subject in the following commit.
commit da6f3e45ddb68ab3161076e120e7c32cfd46d1db
Author: Alvaro Herrera <alvhe...@alvh.no-ip.org>
Date: Sat Apr 14 21:12:14 2018 -0300
Reorganize partitioning code
Attached a patch.
Thanks,
Amit
From 82113b74c2b385eb66be0c6be6e47aa639eaa3e7 Mon Sep 17 00:00:00 2001
From: amit <amitlangot...@gmail.com>
Date: Wed, 4 Jul 2018 11:34:30 +0900
Subject: [PATCH v1] Move PartitionDispatchData definition to execPartition.c.
It has no business being exposed for the whole world to see what's
inside it.
---
src/backend/executor/execPartition.c | 28 ++++++++++++++++++++++++++++
src/include/executor/execPartition.h | 30 +-----------------------------
2 files changed, 29 insertions(+), 29 deletions(-)
diff --git a/src/backend/executor/execPartition.c
b/src/backend/executor/execPartition.c
index 7a4665cc4e..8b7342ae52 100644
--- a/src/backend/executor/execPartition.c
+++ b/src/backend/executor/execPartition.c
@@ -31,6 +31,34 @@
#include "utils/rls.h"
#include "utils/ruleutils.h"
+/*-----------------------
+ * PartitionDispatch - information about one partitioned table in a partition
+ * hierarchy required to route a tuple to one of its partitions
+ *
+ * reldesc Relation descriptor of the table
+ * key Partition key information of the table
+ * keystate Execution state required for expressions in the
partition key
+ * partdesc Partition descriptor of the table
+ * tupslot A standalone TupleTableSlot initialized with this
table's tuple
+ * descriptor
+ * tupmap TupleConversionMap to convert from the parent's rowtype
to
+ * this table's rowtype (when extracting the
partition key of a
+ * tuple just before routing it through this table)
+ * indexes Array with partdesc->nparts members (for details on what
+ * individual members represent, see how they are
set in
+ * get_partition_dispatch_recurse())
+ *-----------------------
+ */
+typedef struct PartitionDispatchData
+{
+ Relation reldesc;
+ PartitionKey key;
+ List *keystate; /* list of ExprState */
+ PartitionDesc partdesc;
+ TupleTableSlot *tupslot;
+ TupleConversionMap *tupmap;
+ int *indexes;
+} PartitionDispatchData;
static PartitionDispatch *RelationGetPartitionDispatchInfo(Relation rel,
int
*num_parted, List **leaf_part_oids);
diff --git a/src/include/executor/execPartition.h
b/src/include/executor/execPartition.h
index 862bf65060..8d6500dcfc 100644
--- a/src/include/executor/execPartition.h
+++ b/src/include/executor/execPartition.h
@@ -18,35 +18,7 @@
#include "nodes/plannodes.h"
#include "partitioning/partprune.h"
-/*-----------------------
- * PartitionDispatch - information about one partitioned table in a partition
- * hierarchy required to route a tuple to one of its partitions
- *
- * reldesc Relation descriptor of the table
- * key Partition key information of the table
- * keystate Execution state required for expressions in the
partition key
- * partdesc Partition descriptor of the table
- * tupslot A standalone TupleTableSlot initialized with this
table's tuple
- * descriptor
- * tupmap TupleConversionMap to convert from the parent's rowtype
to
- * this table's rowtype (when extracting the
partition key of a
- * tuple just before routing it through this table)
- * indexes Array with partdesc->nparts members (for details on what
- * individual members represent, see how they are
set in
- * get_partition_dispatch_recurse())
- *-----------------------
- */
-typedef struct PartitionDispatchData
-{
- Relation reldesc;
- PartitionKey key;
- List *keystate; /* list of ExprState */
- PartitionDesc partdesc;
- TupleTableSlot *tupslot;
- TupleConversionMap *tupmap;
- int *indexes;
-} PartitionDispatchData;
-
+/* See execPartition.c for the definition. */
typedef struct PartitionDispatchData *PartitionDispatch;
/*-----------------------
--
2.11.0
