On Fri, 2024-06-14 at 15:38 +0800, Winter Loo wrote: > I am using gcc version 11.3.0 to compile postgres source code. Gcc complains > about the following line: > > strncpy(sqlca->sqlstate, "YE001", sizeof(sqlca->sqlstate)); > > with error as: > > misc.c:529:17: error: ‘strncpy’ output truncated before terminating nul > copying 5 bytes from a string of the same length [-Werror=stringop-truncation] > > I find the definition of `sqlca->sqlstate` and it has only 5 bytes. When the > statement > > strncpy(sqlca->sqlstate, "YE001", sizeof(sqlca->sqlstate)); > > get executed, `sqlca->sqlstate` will have no '\0' byte which makes me anxious > when someone prints that as a string. Indeed, I found the code(in > src/interfaces/ecpg/ecpglib/misc.c) does that, > > fprintf(debugstream, "[NO_PID]: sqlca: code: %ld, state: %s\n", > sqlca->sqlcode, sqlca->sqlstate); > > Is there any chance to fix the code?
I agree that that is wrong. We could either use memcpy() to avoid the warning and use a format string with %.*s in fprintf(), or we could make the "sqlstate" one byte longer. I think that the second option would be less error-prone. Yours, Laurenz Albe
