On Tue, Jun 18, 2024 at 10:29 AM Maxim Orlov <orlo...@gmail.com> wrote: > Maybe, I'm too bold, but looks like a kinda bug to me. At least, I don't > understand why we do not check the HEAP_XMAX_INVALID flag. > My guess is nobody noticed, that MultiXactIdIsValid call does not check the > mentioned flag in the "first" condition, but it's all my speculation.
A related code path was changed in commit 02d647bbf0. That change made the similar xmax handling that covers XIDs (not MXIDs) *stop* doing what you're now proposing to do in the Multi path. Why do you think this is a bug? > Does anyone know if there are reasons to deliberately ignore the HEAP_XMAX > INVALID flag? Or this is just an unfortunate oversight. HEAP_XMAX_INVALID is just a hint. -- Peter Geoghegan
