On Wed, Jun 19, 2024 at 6:46 AM Peter Smith <smithpb2...@gmail.com> wrote: > > On Tue, Jun 18, 2024 at 9:40 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > On Tue, Jun 18, 2024 at 12:11 PM Peter Smith <smithpb2...@gmail.com> wrote: > > > > > > While reviewing another thread that proposes to include "generated > > > columns" support for logical replication [1] I was looking for any > > > existing PostgreSQL documentation on this topic. > > > > > > But, I found almost nothing about it at all -- I only saw one aside > > > mention saying that logical replication low-level message information > > > is not sent for generated columns [2]. > > > > > > ~~ > > > > > > IMO there should be some high-level place in the docs where the > > > behaviour for logical replication w.r.t. generated columns is > > > described. > > > > > > > +1. > > > > > There are lots of candidate places which could talk about this topic. > > > * e.g.1 in "Generated Columns" (section 5.4) > > > * e.g.2 in LR "Column-Lists" docs (section 29.5) > > > * e.g.3 in LR "Restrictions" docs (section 29.7) > > > * e.g.4 in the "CREATE PUBLICATION" reference page > > > > > > For now, I have provided just a simple patch for the "Generated > > > Columns" section [3]. Perhaps it is enough. > > > > > > > Can we try to clarify if their corresponding values are replicated? > > > > Sure. Here are some current PG17 observed behaviours demonstrating > that generated columns are not replicated. >
Thanks for sharing examples. Your proposed patch as-is looks good to me. We should back-patch this unless you or someone else thinks otherwise. -- With Regards, Amit Kapila.