Dear Amit, Euler, Thanks for giving comment! 0001 was modified per suggestions.
> Yeah, it is a good idea to add a new option for two_phase but that > should be done in the next version. For now, I suggest updating the > docs and probably raising a warning (if max_prepared_transactions != > 0) as suggested by Noah. This WARNING is useful because one could > expect that setting max_prepared_transactions != 0 means apply will > happen at prepare time after the subscriber is created by this tool. > The WARNING will be useful even if we support two_phase option as the > user may have set the non-zero value of max_prepared_transactions but > didn't use two_phase option. I also think it should be tunable, in PG18+. 0002 adds a description in doc. Also, this executable warns if the max_prepared_transactions != 0 on the publisher. Subscriber-side is not checked now because I don't think it is helpful, but it can be easily added. I did not add test for that, because current test code does not check outputs. Best Regards, Hayato Kuroda FUJITSU LIMITED https://www.fujitsu.com/
v2-0001-pg_createsubscriber-Fix-cases-which-connection-pa.patch
Description: v2-0001-pg_createsubscriber-Fix-cases-which-connection-pa.patch
v2-0002-pg_createsubscriber-Warn-the-two-phase-is-disable.patch
Description: v2-0002-pg_createsubscriber-Warn-the-two-phase-is-disable.patch
