On 2018/07/05 23:02, Robert Haas wrote: > On Wed, Jul 4, 2018 at 3:09 AM, Amit Langote > <langote_amit...@lab.ntt.co.jp> wrote: >> I wonder why we mention on the following page that CREATE COLLATION >> requires SHARE ROW EXCLUSIVE lock >> >> https://www.postgresql.org/docs/devel/static/explicit-locking.html >> >> I know that's the lock taken on the pg_collation catalog, but do we need >> to mention locks taken by a DDL command on the catalogs it affects? All >> other commands mentioned on the page require to specify the table name >> that the lock will be taken on. > > Yes, that looks odd.
OK, here is a patch. I see that it was one of Peter E's commits that added that, so cc'd him. Thanks, Amit
diff --git a/doc/src/sgml/mvcc.sgml b/doc/src/sgml/mvcc.sgml index 24613e3c75..4ec853b77a 100644 --- a/doc/src/sgml/mvcc.sgml +++ b/doc/src/sgml/mvcc.sgml @@ -970,8 +970,7 @@ ERROR: could not serialize access due to read/write dependencies among transact </para> <para> - Acquired by <command>CREATE COLLATION</command>, - <command>CREATE TRIGGER</command>, and many forms of + Acquired by <command>CREATE TRIGGER</command>, and many forms of <command>ALTER TABLE</command> (see <xref linkend="sql-altertable"/>). </para> </listitem>