Hi Richard Guo Thank you for updating the patch.Tested on v8 , It looks good to me
Thanks Richard Guo <guofengli...@gmail.com> 于2024年7月4日周四 17:18写道: > On Fri, Jun 28, 2024 at 3:21 PM Richard Guo <guofengli...@gmail.com> > wrote: > > On Fri, Jun 28, 2024 at 2:54 PM Richard Guo <guofengli...@gmail.com> > wrote: > > > I've refined this test case further to make it more stable by using an > > > additional filter 'a.tenthous < 5000'. Besides, I noticed a surplus > > > blank line in ExecHashJoinImpl(). I've removed it in the v7 patch. > > > > BTW, I've also verified the empty-rel optimization for hash join and > > AFAICT it works correctly for the new right-semi join. > > Here is a new rebase. > > Barring objections, I'm planning to push it soon. > > Thanks > Richard >