On Fri, Jul 12, 2024 at 04:50:17PM -0700, Jeff Davis wrote: > On Fri, 2024-07-12 at 16:11 -0700, Noah Misch wrote: > > Since refresh->relation is a RangeVar, this departs from the standard > > against > > repeated name lookups, from CVE-2014-0062 (commit 5f17304). > > Interesting, thank you. > > I did a rough refactor and attached v3. Aside from cleanup issues, is > this what you had in mind?
> +extern ObjectAddress RefreshMatViewByOid(Oid matviewOid, bool skipData, bool > concurrent, > + > const char *queryString, ParamListInfo params, > + > QueryCompletion *qc); > Yes, that's an API design that avoids repeated name lookups.