Hi, > /* > * Prevent spurious warning due to compiler not realizing > * VARATT_IS_EXTERNAL_NON_EXPANDED() branch in assign_simple_var() > isn't > * reachable due to "found" being byvalue. > */ > if (var->datatype->typlen != 1) > pg_unreachable(); > > I'm somewhat inclined to think it'd be worth adding something along those > lines to avoid this warning ([1]).
IMO we shouldn't allow warnings to appear in release builds, even harmless ones. Otherwise we start ignoring them and will skip something important one day. So I think we should do this. -- Best regards, Aleksander Alekseev
