On Mon, Aug 19, 2024 at 1:30 AM Thomas Munro <thomas.mu...@gmail.com> wrote: > > On Mon, Aug 19, 2024 at 12:10 AM Thomas Munro <thomas.mu...@gmail.com> wrote: > > I'm not sure why the first one started happening at the commit > > (aa2d6b15) that caused the second one, I feel like I'm missing > > something...
Thanks, Thomas, for addressing the missing include. Adding logging.h to the pg_verifybackup.h file makes it redundant in pg_verifybackup.c. The attached patch proposes removing this redundant include from pg_verifybackup.c, along with a few other unnecessary includes. Regards, Amul
From 33ccca65daacb44cfb526bdabcd3a3d9c06443f1 Mon Sep 17 00:00:00 2001 From: Amul Sul <amul.sul@enterprisedb.com> Date: Tue, 20 Aug 2024 09:44:56 +0530 Subject: [PATCH] Remove unnecessary #include statements. --- src/bin/pg_verifybackup/pg_verifybackup.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/bin/pg_verifybackup/pg_verifybackup.c b/src/bin/pg_verifybackup/pg_verifybackup.c index 3fcfb167217..2a461079a38 100644 --- a/src/bin/pg_verifybackup/pg_verifybackup.c +++ b/src/bin/pg_verifybackup/pg_verifybackup.c @@ -18,9 +18,6 @@ #include <sys/stat.h> #include <time.h> -#include "common/logging.h" -#include "common/parse_manifest.h" -#include "fe_utils/simple_list.h" #include "getopt_long.h" #include "pg_verifybackup.h" #include "pgtime.h" -- 2.18.0
