Re: Logical Replication of sequences

[Peter Smith]

Hi Vignesh, Here are my only review comments for the latest patch set.

v20240820-0003.

nit - missing period for comment in FetchRelationStates
nit - typo in function name 'ProcessSyncingTablesFoSync'

======
Kind Regards,
Peter Smith.
Fujitsu Australia

diff --git a/src/backend/replication/logical/syncutils.c 
b/src/backend/replication/logical/syncutils.c
index b8f9300..705a330 100644
--- a/src/backend/replication/logical/syncutils.c
+++ b/src/backend/replication/logical/syncutils.c
@@ -96,7 +96,7 @@ SyncProcessRelations(XLogRecPtr current_lsn)
                        break;
 
                case WORKERTYPE_TABLESYNC:
-                       ProcessSyncingTablesFoSync(current_lsn);
+                       ProcessSyncingTablesForSync(current_lsn);
                        break;
 
                case WORKERTYPE_APPLY:
@@ -143,7 +143,7 @@ FetchRelationStates(bool *started_tx)
                        *started_tx = true;
                }
 
-               /* Fetch tables that are in non-ready state */
+               /* Fetch tables that are in non-ready state. */
                rstates = GetSubscriptionRelations(MySubscription->oid, true);
 
                /* Allocate the tracking info in a permanent memory context. */
diff --git a/src/backend/replication/logical/tablesync.c 
b/src/backend/replication/logical/tablesync.c
index ad92b84..c753f45 100644
--- a/src/backend/replication/logical/tablesync.c
+++ b/src/backend/replication/logical/tablesync.c
@@ -237,7 +237,7 @@ wait_for_worker_state_change(char expected_state)
  * SYNCDONE and finish.
  */
 void
-ProcessSyncingTablesFoSync(XLogRecPtr current_lsn)
+ProcessSyncingTablesForSync(XLogRecPtr current_lsn)
 {
        SpinLockAcquire(&MyLogicalRepWorker->relmutex);
 
diff --git a/src/include/replication/worker_internal.h 
b/src/include/replication/worker_internal.h
index 24f74ab..6504b70 100644
--- a/src/include/replication/worker_internal.h
+++ b/src/include/replication/worker_internal.h
@@ -264,7 +264,7 @@ extern void UpdateTwoPhaseState(Oid suboid, char new_state);
 
 extern bool FetchRelationStates(bool *started_tx);
 extern bool WaitForRelationStateChange(Oid relid, char expected_state);
-extern void ProcessSyncingTablesFoSync(XLogRecPtr current_lsn);
+extern void ProcessSyncingTablesForSync(XLogRecPtr current_lsn);
 extern void ProcessSyncingTablesForApply(XLogRecPtr current_lsn);
 extern void SyncProcessRelations(XLogRecPtr current_lsn);
 extern void SyncInvalidateRelationStates(Datum arg, int cacheid,