Hi, thanks for the revision. > >+ Add ON CONFLICT DO NOTHING clause in the INSERT commands. > >I think this would be better as: Add <literal>ON CONFLICT DO NOTHING</literal> >to ><command>INSERT</command> commands.
Agreed. >+ printf(_(" --on-conflict-do-nothing dump data as INSERT >commands with ON CONFLICT DO NOTHING \n")); > >That's slightly misleading... let's just use the same wording again, eg "add ON >CONFLICT DO NOTHING to INSERT commands". Agreed. But you forgot fixing it at pg_dump.c. So could you please fix this and commit it? Regards, Takeshi Ideriha