On Wed, Sep 18, 2024 at 2:49 PM shveta malik <shveta.ma...@gmail.com> wrote: > > > > Please find the attached v46 patch having changes for the above review > > > comments and your test review comments and Shveta's review comments. > > >
When the synced slot is marked as 'inactive_timeout' invalidated on hot standby due to invalidation of publisher 's failover slot, the former starts showing NULL' inactive_since'. Is this intentional behaviour? I feel inactive_since should be non-NULL here too? Thoughts? physical standby: postgres=# select slot_name, inactive_since, invalidation_reason, failover, synced from pg_replication_slots; slot_name | inactive_since | invalidation_reason | failover | synced -------------+----------------------------------+---------------------+----------+-------- sub2 | 2024-09-18 15:20:04.364998+05:30 | | t | t sub3 | 2024-09-18 15:20:04.364953+05:30 | | t | t After sync of invalidation_reason: slot_name | inactive_since | invalidation_reason | failover | synced -------------+----------------------------------+---------------------+----------+-------- sub2 | | inactive_timeout | t | t sub3 | | inactive_timeout | t | t thanks shveta
