On Thu, 12 Jul 2018 17:44:48 +0900
Amit Langote <langote_amit...@lab.ntt.co.jp> wrote:
> > 1) Allow to appear more than once in range partition key
> >
> > I don't understand why there is this restriction. If we have no clear
> > reason,
> > can we rip out this restrition?
>
> I can't recall exactly, but back when I wrote this code, I might have been
> thinking that such a feature is useless and would actually just end up
> being a foot gun for users.
>
> Although, I'm open to ripping it out if it's seen as being overly restrictive.
I think this way is good to resolve this, because allowing columns to appear
more
than once would be harmless at least with the current partitioning methods,
range and hash, although this is useless.
Actually, we currenly allow same expression apears more than once in partition
key
like
create table t (i int) partition by range((i+1),(i+1));
In the past, I proposed a patch to forbid this, but this is rejected
since there is harmless and no need to restrict this.
Attached is a patch to get rid of "appears more than once" restriction.
Regards,
--
Yugo Nagata <nag...@sraoss.co.jp>
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 22e81e7..d7e8633 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -13623,20 +13623,6 @@ transformPartitionSpec(Relation rel, PartitionSpec *partspec, char *strategy)
PartitionElem *pelem = castNode(PartitionElem, lfirst(l));
ListCell *lc;
- /* Check for PARTITION BY ... (foo, foo) */
- foreach(lc, newspec->partParams)
- {
- PartitionElem *pparam = castNode(PartitionElem, lfirst(lc));
-
- if (pelem->name && pparam->name &&
- strcmp(pelem->name, pparam->name) == 0)
- ereport(ERROR,
- (errcode(ERRCODE_DUPLICATE_COLUMN),
- errmsg("column \"%s\" appears more than once in partition key",
- pelem->name),
- parser_errposition(pstate, pelem->location)));
- }
-
if (pelem->expr)
{
/* Copy, to avoid scribbling on the input */
