On Fri, Jul 13, 2018 at 11:31:31AM -0400, Alvaro Herrera wrote: >> Mr. Robot has been complaining about this patch set, so attached is a >> rebased version. Thinking about it, I would tend to just merge 0001 and >> give up on 0002 as that may not justify future backpatch pain. Thoughts >> are welcome. > > I vote to push both.
Thanks! Did you look at the code? The first patch is just some cleanup, while the second could have adjustments? For the second I went with the minimal amount of work, and actually there is no need to make ReadTransientFile() return a status per my study of ReadTwoPhaseFile() in https://postgr.es/m/20180709050309.gm1...@paquier.xyz which must fail when reading the file. So patch 0002 depends on the other 2PC patch. -- Michael
signature.asc
Description: PGP signature