On Mon, Nov 18, 2024 at 4:50 PM Tom Lane <[email protected]> wrote: > > Masahiko Sawada <[email protected]> writes: > > On Mon, Nov 18, 2024 at 3:41 PM Heikki Linnakangas <[email protected]> wrote: > >> While we're at it, I noticed that lib/radixtree.h includes "postgres.h". > >> That's against our usual convention. > > > Good catch. I've updated the patch accordingly. > > Probably out of scope for this particular patch, but it occurred to me > to grep for other similar violations, and I found three: > > src/bin/pg_combinebackup/copy_file.h:#include "c.h" > src/include/fe_utils/option_utils.h:#include "postgres_fe.h" > src/include/fe_utils/query_utils.h:#include "postgres_fe.h"
Good catch, make sense to fix them too. Probably we can fix them including the removal of inclusion of postgres.h from radixtree.h in one commit, and fix the inclusion issue in radixtree.h in another commit. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
