The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: not tested
Hi Paul,
this is a review of the patch:
CABQrizc90sfkZgi4=+0bbp1zu3yex9sm4rjbe1yncvzf3qk...@mail.gmail.com
There hasn't been any problem, at least that I've been able to find.
This one applies cleanly.
Compile, pg_upgrade and pg_dumpall passed without error too.
Follow below a comparison of the results of the pg_dumpall:
############# Without patch #############
...
CREATE TABLE public.t111 (
a40 bit varying(5) DEFAULT (B'1'::"bit")::bit varying
);
...
CREATE TABLE public.t222 (
a40 bit varying(5) DEFAULT B'1'::"bit"
);
############# With patch #############
...
CREATE TABLE public.t111 (
a40 bit varying(5) DEFAULT ('1'::"bit")::bit varying
);
...
CREATE TABLE public.t222 (
a40 bit varying(5) DEFAULT '1'::"bit"
);
The "B", used to indicated a bit-string constant, removed as expected.
+1 for committer review
--
Davy Machado
