Re: pg_attribute_noreturn(), MSVC, C11

[Peter Eisentraut]

On 10.03.25 14:58, Andres Freund wrote:
diff --git a/src/backend/utils/mmgr/slab.c b/src/backend/utils/mmgr/slab.c
index ec8eddad863..d32c0d318fb 100644
--- a/src/backend/utils/mmgr/slab.c
+++ b/src/backend/utils/mmgr/slab.c
@@ -601,8 +601,8 @@ SlabAllocFromNewBlock(MemoryContext context, Size size, int 
flags)
   *            want to avoid that.
   */
  pg_noinline
+pg_noreturn
  static void
-pg_attribute_noreturn()
  SlabAllocInvalidSize(MemoryContext context, Size size)
  {
        SlabContext *slab = (SlabContext *) context;
Hm, is it good to put the pg_noreturn after the pg_noinline?

I probably just did them alphabetically.  I don't think there would be a 
problem, since pg_noinline is an attribute, and they can generally be 
put everywhere.  At least until we learn otherwise.