On Wed, Jun 25, 2025 at 2:57 PM shveta malik wrote: > > > > > Here is the V41 patch set which includes the following changes: > > > > Thanks for the patches. Few trivial things: > > 1) > In ReplicationSlotAcquire(), does it make more sense to move the error after > checking the slot's existence first? If a user is trying to use a slot which > does > not exist, he should first get that error instead of 'slot is reserved' error. > > 2) > When max_replication_slots limit is reached and user is trying to enable rci > for > the first time, launcher will give error in log file: > > ERROR: all replication slots are in use > HINT: Free one or increase "max_replication_slots". > LOG: background worker "logical replication launcher" (PID 13147) exited > with exit code 1 > > It is not clear from this message as to what launcher was actually trying to > create. A log-msg in CreateConflictDetectionSlot() saying "Creating > conflict-detection slot" may help here.
Thanks for the comments. All of them look good to me and have been addressed in V42. Best Regards, Hou zj
