Hi, On Wed, Jun 25, 2025 at 11:00:38AM +0200, Christoph Berg wrote: > Re: Bertrand Drouvot > > +/* > > + * Work around Linux kernel bug in 32-bit compat mode: do_pages_stat() has > > + * incorrect pointer arithmetic for more than DO_PAGES_STAT_CHUNK_NR pages. > > + */ > > +#if SIZEOF_SIZE_T == 4 > > I was also missing it in my suggested patch draft, but this should > probably include #ifdef __linux__.
I'm not sure because the workaround is after this part of the code in pg_numa.c: " /* * At this point we provide support only for Linux thanks to libnuma, but in * future support for other platforms e.g. Win32 or FreeBSD might be possible * too. For Win32 NUMA APIs see * https://learn.microsoft.com/en-us/windows/win32/procthread/numa-support */ #ifdef USE_LIBNUMA " So I guess that the "#ifdef __linux__" would have to be at a higher level anyway (should we support NUMA on more than Linux in the future). Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
