On 2025/06/27 11:55, Shinya Kato wrote:
I thought about the approach, and had a minor concern about the following inconsistency between the option and its internal implementation: - When the option is set to "MATCH", header_line becomes -1. - When the option is set to -1, it's an error.
I think this inconsistency is acceptable, since users won't encounter it directly. Also the value -1 isn't used explicitly, i.e., it's always referenced through a macro for "match", which keeps the code readable and understandable.
However, your patch is clear, and it seems we don't need to worry about this concern. Your patch looks good to me.
Thanks for reviewing the patch! I've marked it as ready for committer. Regards, -- Fujii Masao NTT DATA Japan Corporation
