On Wed, Jun 25, 2025 at 3:46 AM Nazir Bilal Yavuz <byavu...@gmail.com> wrote: > I wanted to experiment with it.
That was fast, thank you! > First, I got the current list of > features from upstream, then disabled the auto features, then > explicitly enabled these features. I did this only for FreeBSD to show > my idea roughly. > > There are two patches; 0001 disables auto features for all of the > tasks and 0002 explicitly enables these features for FreeBSD. Just from a stylistic perspective, I think I'd prefer for `--auto-features=disabled` to be folded into the beginning of the MESON_FEATURES variable. Or is there another reason to control them fully independently? Also: how do we ensure that none of the previously enabled features were missed in this list, for all the OSes we've modified? (I'm a Meson novice.) > What do you think about this approach? If you are okay with this, I > can apply it to all CI tasks (and possibly create another thread for > it). Seems good to me. I think a new top-level thread would be good too, to get more eyes on the changes. Thanks! --Jacob
