On Wed, Jul 02, 2025 at 12:38:01AM +0000, Andy Fan wrote: > However this is not true in BootstrapMode, this failure is masked by > default because TransactionTreeSetCommitTsData returns fast when > track_commit_timestamp is off.
Agreed that there is no point in registering a commit timestamp in the cases of a frozen and bootstrap XIDs. I would recommend to keep the assertion in TransactionIdSetCommitTs(), though, that still looks useful to me for the many callers of this routine, at least as a sanity check. I did not check, but usually we apply filters based on IsBootstrapProcessingMode() for code paths that we do not want to reach while in bootstrap mode. Could the same be done here? -- Michael
signature.asc
Description: PGP signature
