On Wed, Jul 2, 2025 at 3:34 AM Melanie Plageman <melanieplage...@gmail.com> wrote: > > On Tue, Jul 1, 2025 at 12:01 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > > > I've attached the updated patches for master and backbranches (v17 and > > v18). Please review these patches. > > All look good to me. One nitpick that is up to you if you want to > change: the comment > > * Return the number of tuples deleted from the page during HOT pruning. > > is at the top of the function block comment for lazy_scan_prune() in > your patch. Most of the function block comments in vacuumlazy.c list > the return value last after describing the other parameters and use > "Returns" as opposed to the imperative conjugation "Return". >
I've pushed the fix after incorporating your comments. Thank you for reviewing the patch! Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
