Dear Michael, > I like the addition of an extra pg_logical_emit_message() in test 046 > anyway, down to v17, in the test 046 for all the branches. Even if > the reproduction is sporadic, we have seen it pretty quickly in the CI > and in the buildfarm so it would not go unnoticed for a long time if > we mess up with this stuff again.
I put pg_logical_emit_message() after injection_points_wakeup(), but your patch puts it before. I verified even your patch can reproduce the issue, but is there a reason? (This is not a comment which must be fixed, I just want to know the reason to study) > With all that said, I'll move on with this stuff once the embargo for > v18 beta2 is lifted and the tag is pushed. That should happen in 24h > or so, I guess. The provided patches looks good to me. Best regards, Hayato Kuroda FUJITSU LIMITED
