Jim Jones <jim.jo...@uni-muenster.de> writes: > Out of curiosity, what's the reasoning behind keeping node_list instead > of directly using parsed_nodes in the xmlParseBalancedChunkMemory call?
In the original coding, there was a hazard of the node list getting leaked if the caller passed parsed_nodes == NULL. Or at least I thought there was. It may be that all releases of libxml2 are smart enough to free the node list if there's no way to pass it back, but I guess we had reason not to trust it. Possibly there's something about that in the discussion that led up to 6082b3d5d, though I see I neglected to mention it in the commit message. regards, tom lane