Hi! > On 31 Aug 2025, at 21:17, Arseniy Mukhin <[email protected]> wrote: > > PFA the patch that migrates BRIN vacuum to the read stream API.
The patch is nice and straightforward. Looks good to me. Some notes that do not seem to me problem of this patch: 1. This comment is copied 7 times already across codebase. "It is safe to use batchmode as block_range_read_stream_cb" Maybe we can refactor comments and function names... 2. Somehow brin_vacuum_scan() avoid dance of getting RelationGetNumberOfBlocks() many times to be entirely sure everything is scanned. Unlike other index vacuums, see btvacuumscan() for example. Best regards, Andrey Borodin.
