> On Mon, Sep 08, 2025 at 02:47:26PM -0500, Sami Imseih wrote: > > I think v2 is fine because it is perfectly fine for a normal backend > > (EXEC_BACKEND) to call this function as long as it's processing the > > startup hook. The goal is to prevent it from being called outside of the > > startup hook. > > I thought the goal was to prevent the crashes...
yes it is. Ok, I see what I did wrong with my test that showed v2 working in EXEC_BACKEND. when it was reentering the startup hook, it was skipping the code under (!found) for shared memory existing. That is also where I had the code to call GetNamedLWLockTranche. So, that's wrong ( which is what you also mentioned above) I moved the GetNamedLWLockTranche outside of the (!found) block in the test. > > I think we should commit these tests as well. If you think the tests > > should be a separate thread, let me know. > > Thanks. I think we can discuss them here once we fix $SUBJECT. (BTW it > looks like you forgot to attach the patches.) oops. Attached now. -- Sami
v4-0002-Tests-for-LWLock-tranche-registration-improvement.patch
Description: Binary data
v4-0001-Move-named-LWLock-tranche-request-array-to-shared.patch
Description: Binary data
