> Just my 2c while looking at this particular part of the thread.  Now
> to the main patch proposed, v8 or v10..

I have been thinking about whether test coverage is worth it for temp
file logging. I think it is, but others may disagree. However, I also
don't think the current tests are correct.

For example, this is not true. We should now always log the correct query.
```
    ok(0, "The wrong query has been logged");
```

Also, the tests should be checking that we are logging "temporary file: "
before the next statement is logged.

I split up the actual fix and the corrected tests into separate patches.
They can be committed together if there is agreement that tests are worth it.

--
Sami

Attachment: v11-0001-Fix-temp-file-log-blame-for-unnamed-portals.patch
Description: Binary data

Attachment: v11-0002-Add-tests-for-temp-table-logging.patch
Description: Binary data

Reply via email to