> On 17 Sep 2025, at 19:51, Masahiko Sawada <[email protected]> wrote:

> Thank you for updating the patch! I've done additional tests in my
> environment and all test cases passed. One very minor comment is that
> we might want to add 'BASE64URL' to:
> 
> /*
> * BASE64
> */

I did that, and polished a few comments which had various version of case on
"base64url".  The RFC only mentions it in all lowercase so I went with that
apart from the in the comment mentioned above.

The attached v9 has this and

> Overall, the patch looks good to me. I'll wait for Daniel as he has
> polished this patch and might have some comments or want to take it.

Agreed, I think this is ready to go in.  If you want to push it then feel free,
else I'll take care of it tomorrow.

--
Daniel Gustafsson

Attachment: v9-0001-Add-support-for-base64url-encoding-and-decoding.patch
Description: Binary data

Reply via email to