On Tue, 7 Oct 2025 at 11:46, Michael Paquier <[email protected]> wrote: > > On Wed, Oct 01, 2025 at 03:39:35PM +0900, Michael Paquier wrote: > > + int32 ntuples; > > + ntuples = ((ginxlogUpdateMeta *) rec)->ntuples; > > + appendStringInfo(buf, "ntuples: %d", ntuples); > > > > In 0002. We have a routine for this type of assignments: > > XLogRecGetBlockData(). Let's use it here for clarity. > > This should be XLogRecGetData(), not XLogRecGetBlockData(), as the > data is assigned to the record. My apologies for the mistake. > -- > Michael
Yes, thank you. Turns out we already use XLogRecGetData in assignment: char *rec = XLogRecGetData(record). But I still did alter v2 patch a bit, introducing new variable xlrec, to avoid clunky casts between char * and ginxlogUpdateMeta. FPA v3. -- Best regards, Kirill Reshke
v3-0001-Better-gin-pg_waldump.patch
Description: Binary data
