Please find a few more comments on 002:
1)
- This catalog only contains tables known to the subscription after running
+ This catalog only contains tables and sequences known to the
subscription after running
Shall we get rid of 'only' now?
2)
+ * A single sequencesync worker synchronizes all sequences, so
+ * only stop workers when relation kind is not sequence.
This comment refers sequencesync worker which is in future patches. Is it okay?
3)
UpdateSubscriptionRelState
if (!HeapTupleIsValid(tup))
elog(ERROR, "subscription table %u in subscription %u
does not exist",
relid, subid);
table -->relation as AlterSubscription_refresh_seq() also invokes this.
4)
check_publications_origin :
if (res->status != WALRCV_OK_TUPLES)
ereport(ERROR,
(errcode(ERRCODE_CONNECTION_FAILURE),
errmsg("could not receive list of
replicated tables from the publisher: %s",
res->err)));
It could be sequences also.
We can either make it as 'replicated tables and/or sequences' or
simply 'replicated relations'
5)
fetch_relation_list:
Same here:
if (res->status != WALRCV_OK_TUPLES)
ereport(ERROR,
(errcode(ERRCODE_CONNECTION_FAILURE),
errmsg("could not receive list of
replicated tables from the publisher: %s",
res->err)));
6)
CreateSubscription:
/*
* Connect to remote side to execute requested commands and fetch table
* info.
*/
We can update this existing comment to mention sequences as well.
thanks
Shveta
