On Mon, Oct 20, 2025 at 05:46:33PM +1300, David Rowley wrote: > I don't think the attached is very interesting to look at, but l'll > leave it here for a bit just in case anyone wants to look. Otherwise, > I plan to just treat it as a follow-up of 5983a4cff.
Still I've looked at it. I like reading code.
The change in validateDomainCheckConstraint()@typecmds.c looks
independent to what you are suggesting here. Grouping that is fine,
just noting that the intent is not the same.
@@ -5146,10 +5146,6 @@ ReorderBufferToastReplace(ReorderBuffer *rb,
ReorderBufferTXN *txn,
dlist_iter it;
Size data_done = 0;
- /* system columns aren't toasted */
- if (attr->attnum < 0)
- continue;
Er, why this removal?
--
Michael
signature.asc
Description: PGP signature
