Hi Tim, Thanks for working on this. I haven’t finished reviewing the entire patch. But I got a quick question:
> On Oct 22, 2025, at 17:32, Tim Waizenegger <[email protected]> > wrote: > > updated patch is attached > > --- > Best regards, > Florin Irion > Tim Waizenegger > > EDB (EnterpriseDB) > <v1-0001-Add-pg_get_domain_ddl-function-to-reconstruct-CRE.patch> ``` +/* + * pg_get_domain_ddl - Get CREATE DOMAIN statement for a domain + */ +Datum +pg_get_domain_ddl(PG_FUNCTION_ARGS) +{ + StringInfoData buf; + Oid domain_oid = PG_GETARG_OID(0); + HeapTuple typeTuple; + Form_pg_type typForm; + Node *defaultExpr; ``` While reviewing a similar patch of pg_get_policy_ddl(), it take the last parameter as a pretty flag. I wonder why pg_get_domain_ddl() doesn’t support an argument for pretty? See the code snippet from the other patch: ``` +/* + * pg_get_policy_ddl + * + * Generate a CREATE POLICY statement for the specified policy. + * + * tableID - Table ID of the policy. + * policyName - Name of the policy for which to generate the DDL. + * pretty - If true, format the DDL with indentation and line breaks. + */ +Datum +pg_get_policy_ddl(PG_FUNCTION_ARGS) +{ + Oid tableID = PG_GETARG_OID(0); + Name policyName = PG_GETARG_NAME(1); + bool pretty = PG_GETARG_BOOL(2); # <====== This is the pretty arg + bool attrIsNull; ``` Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
