On Thu, Oct 23, 2025 at 11:18:09AM +0800, Quan Zongliang wrote: > On 9/19/25 7:16 PM, Aleksander Alekseev wrote: >> Currently waitonlock_error_callback() allocates memory in ErrorContext >> and doesn't explicitly free it. Valgrind is not happy about it and >> generates multiple reports like this: > > Improve the completeness of the code.
errfinish() calls MemoryContextReset() on ErrorContext so as any leaks like the one you are cleaning up are taken care of. Still, what you are suggesting is simple enough and silences a bit valgrind, so agreed about the addition of this pfree(). Let's see if somebody objects to that. -- Michael
signature.asc
Description: PGP signature
