On Wed, 5 Nov 2025 at 18:10, Amit Kapila <[email protected]> wrote: > > On Wed, Nov 5, 2025 at 5:57 PM vignesh C <[email protected]> wrote: > > > > On Wed, 5 Nov 2025 at 13:58, Amit Kapila <[email protected]> wrote: > > > > > > On Mon, Nov 3, 2025 at 8:46 PM vignesh C <[email protected]> wrote: > > > > > > > > The attached v20251103 patch has the changes for the same. > > > > > > > > > > I have pushed the 0001 after making minor adjustments in tests and at > > > a few other places. Kindly rebase and send the remaining patches. > > > > I noticed a buildfarm failure on prion at [1]. > > The test failed on prion because it runs with the following additional > > configuration: > > log_error_verbosity = verbose > > > > Due to this setting, the logs include an extra LOCATION line between > > the WARNING and ERROR messages, which was not expected by the test: > > 2025-11-05 11:35:21.090 UTC [1357163:3] WARNING: 55000: mismatched or > > renamed sequence on subscriber ("public.regress_s4") > > 2025-11-05 11:35:21.090 UTC [1357163:4] LOCATION: > > report_sequence_errors, sequencesync.c:185 > > 2025-11-05 11:35:21.090 UTC [1357163:5] ERROR: 55000: logical > > replication sequence synchronization failed for subscription > > "regress_seq_sub" > > > > I'm working on a fix for this issue. > > > > We can fix it either by expecting just a WARNING for this test which > is sufficient. The other possibility is that we can expect some other > line(s) between WARNING and ERROR. I think just waiting for WARNING in > the log is sufficient as that serves the purpose of this test. What do > you think?
I also think checking only for the WARNING message in the log is sufficient to verify the test. The attached patch includes this change. Alternatively, we could check for the WARNING first and then verify the ERROR separately if needed. Thoughts? Regards, Vignesh
From 5af233ef814a2f834c1208431ae3023bc53e5abd Mon Sep 17 00:00:00 2001 From: Vignesh C <[email protected]> Date: Wed, 5 Nov 2025 18:51:24 +0530 Subject: [PATCH] Fix tap test failure to handle verbose log output The test failed on buildfarm member prion because it runs with log_error_verbosity = verbose, which adds an extra LOCATION: line between the WARNING and ERROR messages. Update the test to only check for the WARNING message to avoid verbosity dependent failures. --- src/test/subscription/t/036_sequences.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/subscription/t/036_sequences.pl b/src/test/subscription/t/036_sequences.pl index d34b0e4ae2f..8112f86d2dd 100644 --- a/src/test/subscription/t/036_sequences.pl +++ b/src/test/subscription/t/036_sequences.pl @@ -201,14 +201,14 @@ $node_subscriber->safe_psql('postgres', # Verify that an error is logged for parameter differences on sequence # ('regress_s4'). $node_subscriber->wait_for_log( - qr/WARNING: ( [A-Z0-9]+:)? mismatched or renamed sequence on subscriber \("public.regress_s4"\)\n.*ERROR: ( [A-Z0-9]+:)? logical replication sequence synchronization failed for subscription "regress_seq_sub"/, + qr/WARNING: ( [A-Z0-9]+:)? mismatched or renamed sequence on subscriber \("public.regress_s4"\)/, $log_offset); # Verify that an error is logged for the missing sequence ('regress_s4'). $node_publisher->safe_psql('postgres', qq(DROP SEQUENCE regress_s4;)); $node_subscriber->wait_for_log( - qr/WARNING: ( [A-Z0-9]+:)? missing sequence on publisher \("public.regress_s4"\)\n.*ERROR: ( [A-Z0-9]+:)? logical replication sequence synchronization failed for subscription "regress_seq_sub"/, + qr/WARNING: ( [A-Z0-9]+:)? missing sequence on publisher \("public.regress_s4"\)/, $log_offset); done_testing(); -- 2.43.0
