Hi Nathan,

I just reviewed the patch. Looks to me the correct three-commit split:

0001 updates tooling/configure so that 0002 will not introduce formatting 
violation
0002 makes large formatting rewrite (tab->white spaces), and so that the commit 
needs to be added to .git-blace-ignore-revs 
0003 adds CI enforcement so that no future patches to reintroduce tabs

A tiny comment about a typo in 0003’s commit message:
```
The previous commit updated this file to use tabs instead of
spaces. 
```

Should be “use spaces instead of tabs”.

> On Nov 18, 2025, at 02:50, Nathan Bossart <[email protected]> wrote:
> 
> Here is a rebased patch set.  Notably, I've split it into three pieces.
> I'm planning to add 0002 to .git-blame-ignore-revs, as testing indicates
> this preserves the blame history reasonably well.
> 
> -- 
> nathan
> <v3-0001-Update-.editorconfig-and-.gitattributes-for-postg.patch><v3-0002-Switch-from-tabs-to-spaces-in-postgresql.conf.sam.patch><v3-0003-Check-for-tabs-in-postgresql.conf.sample.patch>

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/






Reply via email to