On Nov 20 2025, at 5:00 pm, Peter Eisentraut <[email protected]> wrote:
> On 20.11.25 21:45, Greg Burd wrote:
>> Dave and I have been working together to get ARM64 with MSVC functional.
>> The attached patches accomplish that. Dave is the author of the first
>> which addresses some build issues and fixes the spin_delay() semantics,
>> I did the second which fixes some atomics in this combination.
>
Hi Peter,
Thanks for taking a second to review.
> > - zlib_t = dependency('zlib', required: zlibopt)
> > + zlib_t = dependency('zlib', method : 'pkg-config', required: zlibopt)
>
> This appears to be a change unrelated to your patch description.
Hmmm, these are changes that Dave added to get things to compile. They
worked for me but I'll review them again in the morning and update the
description.
> Also, the second patch contains a number of random whitespace changes.
> It would be good to clean that up so the patch is easier to analyze.
Certainly, apologies. I'll clean that up first thing in the morning.
-greg
