> On Nov 21, 2025, at 19:34, Bertrand Drouvot <[email protected]>
> wrote:
>
> Hi hackers,
>
> While working on [1], I noticed that there are unused fields in
> BufferCacheNumaRec
> since ba2a3c2302f.
>
> Also, I noticed that a comment was not at the correct location in
> pg_buffercache_numa_pages().
>
> The attached takes care of both.
As long as compile passes, that proves the removal of the unused fields is
safe. And by reading the code, I believe the movement of the comment is also
correct.
Looks like you have done a little bit rewording on the comment:
1. "This loop stores into os_page_ptrs[]” is understandable, but feels a bit
incomplete to me as non-English-speaking. I understand your intention is to
make “stores” and “touches” to share “addresses”. But this is not a strong
opinion comment, if Michael considers okay, I will be fine as well.
2. Instead of saying “if needed”, why don’t explicitly mention something like
“on the first pass”.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
