Hi Chao, On Thu, Dec 11, 2025 at 3:09 PM Chao Li <[email protected]> wrote: > > Hi, Ashutosh, > > I just quickly went through the patch. Obviously I need more time to fully > understand the patch, I will do a deep review today. In the meantime, I just > caught a nit issue. >
Thanks for your review. > > On Dec 11, 2025, at 12:59, Ashutosh Bapat <[email protected]> > > wrote: > > > > > > Please review. > > > > [1] > > https://www.postgresql.org/message-id/CAA4eK1KzYaq9dcaa20Pv44ewomUPj_PbbeLfEnvzuXYMZtNw0A%40mail.gmail.com > > [2] > > https://www.postgresql.org/message-id/[email protected] > > [3] > > https://www.postgresql.org/message-id/CAExHW5tfVHABuv1moL_shp7oPrWmg8ha7T8CqwZxiMrKror7iw%40mail.gmail.com > > > > -- > > Best Wishes, > > Ashutosh Bapat > > <v20251211-0001-Report-output-plugin-statistics-in-pg_stat.patch> > > 1 > ``` > + linkend="logicaldecoding-output-plugin-callbacks"/>. A descripancy in > those > ``` > > Typo: descripancy => discrepancy > Thanks for pointing this out. I have fixed it my code. However, at this point I am looking for a design review, especially to verify that the new implementation addresses Andres's concern raised in [1] while not introducing any design issues raised earlier e.g. those raised in threads [2], [3] and [4] [1] https://www.postgresql.org/message-id/zzidfgaowvlv4opptrcdlw57vmulnh7gnes4aerl6u35mirelm@tj2vzseptkjk > > [2] > > https://www.postgresql.org/message-id/CAA4eK1KzYaq9dcaa20Pv44ewomUPj_PbbeLfEnvzuXYMZtNw0A%40mail.gmail.com > > [3] > > https://www.postgresql.org/message-id/[email protected] > > [4] > > https://www.postgresql.org/message-id/CAExHW5tfVHABuv1moL_shp7oPrWmg8ha7T8CqwZxiMrKror7iw%40mail.gmail.com -- Best Wishes, Ashutosh Bapat
