Hi, On 2025-12-17 16:15:21 +0100, Peter Eisentraut wrote: > On 16.12.25 23:03, Corey Huinker wrote: > > I've been looking at ways to reorganize and/or clean up pg_dump.c. > > > > One thing I have noticed is the usage of PQExpBuffer in situations where > > the query has no optional parts and no string interpolation. > > > > Attached is a patch to replace those usages with the string literal > > itself. > > I'm not sure this is better. It seems better to me to use consistent APIs > throughout. Kind of like using printf even if you don't need to substitute > anything, rather than using a mix of printf and puts.
It also just seems like a pain for backpatching. If this were a huge improvement or if the code in question was being newly added, it'd perhaps be a different story, but as is... Greetings, Andres Freund
