On Mon, Dec 29, 2025 at 10:33 AM Masahiko Sawada <[email protected]> wrote: > > Hi, > > On Tue, Dec 23, 2025 at 6:18 PM Chao Li <[email protected]> wrote: > > > > Hi Hackers, > > > > While reviewing the patch [1], though I couldn’t raise a comment for it, I > > noticed a comment error in the file pg_visibility.c, where a buffer lock is > > held in shared mode but the code comment mentioned exclusive mode. I am > > filing a small patch to correct the comment. > > > > I only changed "exclusively" to "shared", the format changed was done by > > pgindent. > > Yeah, it seems like a typo since the first commit of pg_visiblity, > e472ce9624e0. I think we can backpatch it to all supported versions. >
I find that "shared locked" sounds unnatural to me. How about rephrasing to "... we're holding the buffer locked in shared mode"? I've attached the patch. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
0001-pg_visibility-Fix-incorrect-buffer-lock-description.patch
Description: Binary data
