Hi Xuneng, On Thu, Jan 8, 2026 at 4:15 PM Xuneng Zhou <[email protected]> wrote:
> > v3-0001 fixes a critical issue where the snapshot->xip array in > SnapBuildBuildSnapshot might not be sorted before reaching the > consistent state. Sorry for the noise here. > > I’ve given this patch a cursory review, and it looks good overall. Considering the impact of this change, should we add a regression test for it, or provide a unit test to ensure the correctness of the modification? I think it would be more receptive to merging such a "subtle performance optimization" only when its correctness is fully guaranteed.
